Update v44 pricefeed addresses to use bytes #1053
Merged
+1,976
−732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| string base_asset = 2; | ||
| string quote_asset = 3; | ||
| repeated bytes oracles = 4 [ | ||
| (cosmos_proto.scalar) = "cosmos.AddressBytes", |
There was a problem hiding this comment.
do you know of any docs on what the (cosmos_proto.scalar) does? I haven't been able to find any.
There was a problem hiding this comment.
Doesn't seem to be used yet, maybe later in cosmos v0.45. Just added to be consistent with swap module
There was a problem hiding this comment.
Changes look good. Couple of additional requests:
- Do you want to separate the proto query types from the store types. See Spike split proto types #1050 and the swap query types.
- There's a TODO in
module.gofor registering invariants. The pricefeed module doesn't have any invariants so we can remove the TODO. - Minor code quality improvements:
CalculateMedianPriceandcalculateMeanPriceare just math functions, so they don't need access to the ctx, so that argument could be removed. AlsocalculateMeanPricewill panic if anyone ever passes in a slice of more than 2 prices. I'd probably swap the slice arg for two individual prices args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.